Fetch transmissions and certificates simultaneously #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicsn
changed the title
d0cd
reviewed
Oct 24, 2024
| // Ensure the primary has all of the transmissions. | ||
| let missing_transmissions = self.fetch_missing_transmissions(peer_ip, batch_header).await.map_err(|e| { | ||
| // Collect any missing transmissions. | ||
| let missing_transmissions = transmissions_promise.await.map_err(|e| { |
There was a problem hiding this comment.
Does it make sense to await at the very end of the function, since we only return the result of the promise?
There was a problem hiding this comment.
Also had that thought! But sync_with_certificate_from_peer below recursively calls back into this function, which could then cause duplicate transmissions to be fetched. Under certain assumptions, that might actually be faster, but it seems cleaner to await fetching transmissions before syncing with new certificates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fetching transmissions poses a significant bottleneck in consensus. This simple change can avoid waiting for a synchronous roundtrip of certificate fetching, which happens almost every round.
Test Plan
Tested on a local devnet with traffic.