Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dev_id to prevent db lock contention during dev genesis creation #3407

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

vicsn
Copy link
Contributor

@vicsn vicsn commented Sep 28, 2024

Motivation

During testing, we often experienced lock contention, apparently because all dev nodes temporarily initialized a DB using dev(0).

Also shortened development_private_keys to dev_keys to prevent cargo fmt from adding many lines of code.

Test Plan

Tested locally. The adjusted load_or_compute_genesis function is only used in dev mode.

@vicsn vicsn requested a review from raychu86 September 28, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant