Refactor of beamcon #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relatively big refactor of the beamcon scripts. Mostly for internal sanity and doing away with dictionaries in favour of namedtuples.
A big change for the attention of @wasimraja81, @axshen and others is that I also remove MPI functionality here. In place, I use threading (through the built-in
concurrent.futuresAPI). This has a nice speed bonus, as well as reducing the code footprint. Since we use Numpy+Numba, or we wait on I/O, the Python GIL is mostly not an issue.The CLI calls remain identical, with the exception of MPI options being removed. If you have big issues with this change, I'm happy to hear feedback.
This will target a major version bump.
Still got some documentation to finish up.