Expose public_on date #73
Open
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr8bit
force-pushed
the
expose_public_on
branch
from
8b4fd52
to
1d3ff27
Compare
gr8bit
force-pushed
the
expose_public_on
branch
from
76de802
to
18002db
Compare
Now pages can be sorted using public_version_public_on field key with "sort" parameter
gr8bit
force-pushed
the
expose_public_on
branch
from
cdd9537
to
23c2190
Compare
|
@gr8bit is this still something you want to work on or can we close this? |
…ose_public_on # Conflicts: # app/controllers/alchemy/json_api/pages_controller.rb
|
Hey @gr8bit I am still thinking this is a valuable addition, but reading the git commit history it seems you are struggling getting this stable. Is there anything I can help with? |
|
Yes indeed, I had a hard time getting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the Page's public_on attribute via the api.