Merge from Valhalla #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated transifex * Update CHANGELOG.md
* implement a fix for destonly edges around ferries, including the ability to not un-tag destonly edges further away from ferries, i.e. where there was a break to destonly continuity * changelog * new changelog block.. * revert most of the previous changes: we only don't penalize any dest_only while reclassifying if the connecting edge was dest_only AND the pred was destonly, but we still untag ANY destonly if it showed up in the final upclassified path; the main change is: also remove the connecting edge's destonly, which #1905 was missing; also fix a bug in forming the upclassified path where the initial label index could be wrong
0a4e828 removed the use values `rail_connection` and `bus_connnection` and added the use values `egress_connection` and `platform_connnection`. The latter value contained a typo (three n) and the commit also didn't update the documentation accordingly. This commit fixes these oversights.
* refactor: rename fo variable to file_op * chore: facilitate spell-checking * fix typo missed in previous PR * ci: generalize changelog workflow to 'GitHub CI' * ci: add spell-checking with typos * Update CHANGELOG.md --------- Co-authored-by: Kevin Kreiser <[email protected]>
* Remove unused variable Apple clang generating this error: error: variable 'found' set but not used [-Werror,-Wunused-but-set-variable] * Replace set with unordered_set std::set is not defined in libc++ on MacOS XCode SDK 12 and is defined with a different type signature in XCode 13. There doesn't seem to be any need for the set to be ordered so this fixes the compilation errors * Add maybe_unused attribute to found variable This was providing a similar error as before: error: variable 'found' set but not used [-Werror,-Wunused-but-set-variable] As the variable is only used when the logging level is set to trace.
* adding basic functionality of side cutoff * added documentation * added roundabout_exits to documentation * applied clang-format * added test * updated changelog * improved search filter order * added comment in tests regarding driving side * applied clang-tidy * Updated description Updated the description to be more understandable. Co-authored-by: Kevin Kreiser <[email protected]> * made street_side_cutoff optional in worker.cc --------- Co-authored-by: = <[email protected]> Co-authored-by: Kevin Kreiser <[email protected]>
* refactor valhalla_add_elevation a bit and move the mjolnir util to baldr * add -j flag to all multithreaded executables * changelog * remove deprecated heder * oops * moved the argparse boilerplate code to a private header which all programs can share * cxxopts entry not needed in cmake * add missing midgard header * some fixes * huch, quite a logical mistake.. * few nits * more fixes * remove left-overs * keep deduplication in the executable valhalla_add_elevation * keep deduplication in the executable valhalla_add_elevation * use __FILE__ to find the executable name; overhaul src/CMakeLists.txt, we need to put the ./src directory to target_include_directories() * move get_tile_ids function into the executable * add filesystem::stem() to return the file name without extension and adapt all executables
* remove just_gtfs official version * use sorted feeds to speed up processing * changelog * use new no copy interfaces with different validity semantics * lint changelog * lint * fix one of the test failures but the calendar part doesnt make sense.. * fix last bug, ready to ship * fix yet another range bug. i see why c++20 made these first class citizens of stl
Co-authored-by: Kevin Kreiser <[email protected]>
* build database for parsed landmarks with tests * remove unnecessary struct Landmark * add bounding box query (TBC) * fix small typo * remove redundant code; code refactor and cleaning; add open db with different access * add access mode in constructor, bounding box query TBC * fix spatialite extension, finalize database builder * formatting * remove test func and fix loading spatilite by storing db_conn in the class * update test with test fixtures * move prepared statements to class member variables * add Vacuum and Analyze; update insert func input param; code cleaning * rename test to test_landmarks.cc * remove unused imports * code cleaning * update interface * tidy * update constructor, remove unnecessary enum * update connect_database func to use exceptions * add release statements * update Changelog
* simplify original class and prepare for pimpl * finish pimpl * formant * changelog
* sudo install python dependencies on OSX * well then.. install cython urgh * huh, wrong python3 maybe, pre-commit depends on pyyaml 6.0 and installs without issues, 5.9 should have a wheel as well, but when downgrading pip decides to build from source instead.. urgh. last resort: pin pre-commit to a version which depends on pyyaml < 6.0, but eventually we'll need to do the conan switch to 2.0 * get rid of cython again..
…es (#4204) * coalesce the various gurka access tests into one * add failing test * add handling for :forward tags for all major modes * lint * update taginfo * changelog * lint * we can delude ourselves that bikes are vehicles
…ags and LOG_LEVEL=WARN (#4197)
* implement callback and landmark parse function - first version * implement landmark parser and test passed * tidy * add BuildLandmarkFromPBF function: parse landmarks from pbf and store them in database * fix bug 'overwrite' * tidy * update Landmark type to enum of uint8_t with 15 popular amenity values, and update database part accordingly * remove redundant func and test, code cleaning * update LandmarkType to include only obvious landmarks for vehicle routing * rename to landmark_builder * move insertion of landmarks into node callback to have them directly inserted in to db after being parsed * move landamark_callback to anonymous namespace * add default values to LandmarkType * update landmark_callback to parse landmark nodes only; update landmark test with border cases * update test detail * change default landmark name to empty string and remove defaults for lat and lng * fix LandmarkDatabase constructoe, and fix rebase issues * remove unnecessary tag 'landmark' in landmark_callback and update test * update landmark_callback to not pass LandmarkDatabase as parameter in constructor * code cleaning * update BuildLandmarkFromPBF interface to take ptree for executable * enable separate executable for landmrk builder * enable valhalla_build_landmarks commandline * fix typo * remove comments * remove struct Landmark and update interface and tests * code cleaning in landmark tests * change landmark database to only allow writes at creation; remove LandmarkType::null; code cleaning * update CHANGELOG.md and description * remove bus_station and biergarten in LandmarkType * address code reviews * add remarks for LandmarkType * address code reviews * update CHANGELOG.md
* [test/gurka/test_traffic.cc] sign-compare: int -> uint32_t * [test/mapmatch.cc] sign-compare: size_t -> int * [test/gurka/test_64bit_wayid.cc] sign-compare: int -> size_t * [test/gurka/test_osrm_serializer.cc] sign-compare: int -> size_t * [test/gurka/test_precision.cc] sign-compare: int -> size_t * [test/gurka/test_time_dependent_tags.cc] sign-compare: int -> size_t * [test/gurka/test_turn_lanes.cc] sign-compare: int -> size_t * [test/http_tiles.cc] sign-compare: int -> size_t * [test/shape_attributes.cc] sign-compare: int -> size_t * [test/viterbi_search.cc] sign-compare: int -> size_t * [test/gurka/test_traffic_smoothing.cc] sign-compare: int -> size_t * [test/recover_shortcut.cc] sign-compare: int -> size_t * [test/gurka/test_match.cc] sign-compare: int -> size_t & invalid/is_valid * [test/gurka/test_route.cc] sign-compare: int -> size_t & invalid/is_valid * [test/gurka/test_osrm_serializer.cc] Using rapidjson::SizeType * [test/http_tiles.cc] Using std::filesystem
* [test/gurka/test_build_admin.cc] Removing unused variables * [test/gurka/test_build_admin.cc] using std::filesystem --------- Co-authored-by: Nils <[email protected]>
* fix crash in timedistancebssmatrix.cc * update changelog.md
* use protobuf's CMake config instead of CMake's own * add todo * ugly workaround * manually find & link abseil to protobuf * changelog * comment out the dll line * boil down to linking only the used abseil library
* fix: links on the optimized route API document * docs: updated changelog
* skeleton for updates to the tile structure * update AddLandmark * fix bugs and code cleaning * add string_to_landmark and vice versa in landmark header * move stuff into baldr * more structure to the test * update Landmark back to struct * update get_landmarks_by_bbox arguments order * problem: sanity checks failed * update Landmark::from_str to constructor * fix encode and decode of lng and lat for landmark * fix typo and argument names * fix null byte bug by updating encoding of Landmark objects * failing test * some ramblings about how to get the data in ther * back to fixed length encoding of Landmark lat and lng; update EdgeInfo::GetTaggedValues and EdgeInfo::GetTags() * fix bug and allow more landmark tests * tidy * fix bug * remove repeated imports * update changelog * use std::move and add to landmark test * address code review * complete test * remove comments and optimize tests * add a new line at the end of file * remove fixed landmark in the test --------- Co-authored-by: Kevin Kreiser <[email protected]> Co-authored-by: Nils <[email protected]>
…ate` and proto `/route` responses (#4851)
Co-authored-by: amaury.zarzelli <[email protected]> Co-authored-by: adrika.mukherjee <[email protected]> Co-authored-by: Johannes Nonnenmacher <[email protected]> Co-authored-by: Janusz <[email protected]>
Co-authored-by: Kevin Kreiser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.