Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix division by zero error #412

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix division by zero error #412

merged 1 commit into from
Aug 11, 2023

Conversation

peterojo
Copy link
Contributor

Summary

Fix division by zero error when cart total is zero.
Issue:

Issue Description / Steps to Reproduce:

-Create a product with a price of €0 and free shipping (or add a 100% discount)

-Add product to the cart

-500 error is thrown

@peterojo peterojo requested a review from a team as a code owner August 11, 2023 09:26
@peterojo peterojo added the Fix Indicates a bug fix label Aug 11, 2023
@peterojo peterojo mentioned this pull request Aug 11, 2023
Merged
@candemiralp candemiralp self-requested a review August 11, 2023 12:11
@candemiralp candemiralp merged commit 074bccf into develop Aug 11, 2023
8 of 9 checks passed
@candemiralp candemiralp deleted the fix-division-by-zero branch February 27, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushboo-singhvi khushboo-singhvi khushboo-singhvi approved these changes

@candemiralp candemiralp candemiralp approved these changes

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterojo @khushboo-singhvi @candemiralp