Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFI-415] setPaymentTransactionType not working for giftcards #1014

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

zenit2001
Copy link
Contributor

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    This PR adjusts the setPaymentTransactionType to cover the scenarios when giftcards are being used, and gives the possibility to treat them as SALE payment methods when synchronizing with OMS. It also fixes the extra space issue when the metadata string is edited from BM config page, which before was leading to the last SALE payment method to be missed.
  • What existing problem does this pull request solve?
    This PR enables the giftcards to be treated as SALE payment methods and fixes the parsing issue when editing the BM fields where SALE payment methods are saved.

Fixed issue: SFI-415

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zenit2001 zenit2001 added the fix Fixes a bug label Nov 21, 2023
@zenit2001 zenit2001 marked this pull request as ready for review November 21, 2023 15:16
@zenit2001 zenit2001 merged commit 9aadc50 into develop Nov 27, 2023
14 of 17 checks passed
@zenit2001 zenit2001 deleted the bugfix/SFI-415-sale_transactions branch November 27, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants