Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-9431] Handling Refund Delay and Order Cancellation Issues when using Giftcard + redirected Payment method #2771

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

khushboo-singhvi
Copy link
Contributor

Description
When a customer places an order using a gift card in combination with any redirected payment method, an order is created which redeems the gift card balance, even if the full payment is not completed. As a result, the customer is unable to use the gift card again, despite the full order is not successfully placed.
This PR handles this situation wherein we cancel the already authorised partial payments(Giftcard Payments) if the payment with the redirect payment method fails.

Tested scenarios
Klarna, 3DS, Ideal Successful and failing situations tested.

Fixes

@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner October 15, 2024 14:39
@khushboo-singhvi khushboo-singhvi changed the title Handling Refund Delay and Order Cancellation Issues when using Giftcard + redirected Payment method [ECP-9431] Handling Refund Delay and Order Cancellation Issues when using Giftcard + redirected Payment method Oct 16, 2024
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
52.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant