Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9482] Refactor HeaderDataBuilder and TransactionClient #2769

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[ECP-9482] Refactor HeaderDataBuilder and TransactionClient #2769

wants to merge 13 commits into from

Conversation

SushmitaThakur
Copy link
Contributor

@SushmitaThakur SushmitaThakur commented Oct 8, 2024 •
edited
Loading

Description
This PR -

  • Refactors HeaderDatabuilder and moves buildHeaderData method from Data helper class to the builder.
  • It adds a HeaderDataBuiderInterface that declares all the header constants.
  • Adds a BaseTransaction client class that accommodates common methods used by all transactions clients
  • Updates all the TransactionClients and PaymentDetails class accordingly
  • Updates all the unit tests related to TransactionClients and PaymentDetails
  • Updates the path to header builder in di.xml
  • Updates relevant observers to use correct frontendType constant
  • Synchronises the frontendType value to luma in JS renderers

Tested Scenarios

  • TransactionPayment
  • TransactionCancel
  • TransactionCapture
  • PaymentDetails Call

sushmita added 2 commits October 8, 2024 15:28
[ECP-9482] Add the ExternalPlatformHeaderDataBuilder Interface and …
dc1b659 
…Builder class, Refactor all the usage of HeaderDataBuilder, Remover header builder from helper class and all its usage, Define header constants, Update dependency injection with new builder name, Synchronise the value of `frontendtype` to `luma` in relevant js files
[ECP-9482] Put magentoDetails method in data class
06aa3c6
@SushmitaThakur SushmitaThakur requested a review from a team as a code owner October 8, 2024 19:48
@SushmitaThakur SushmitaThakur reopened this Oct 9, 2024
@SushmitaThakur SushmitaThakur marked this pull request as draft October 9, 2024 09:36
@SushmitaThakur SushmitaThakur marked this pull request as draft October 14, 2024 22:47
[ECP-9482] Add BaseTransaction client, refactor all transaction clien…
bad7cbc 
…ts and tests, update header data builder tests, remove defaulting frontend type to headless
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SushmitaThakur SushmitaThakur changed the title [ECP-9482] Refactor header data builder [ECP-9482] Refactor HeaderDataBuilder Oct 15, 2024
@SushmitaThakur SushmitaThakur changed the title [ECP-9482] Refactor HeaderDataBuilder [ECP-9482] Refactor HeaderDataBuilder and TransactionClient Oct 15, 2024
@SushmitaThakur SushmitaThakur marked this pull request as ready for review October 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterojo peterojo peterojo left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SushmitaThakur @peterojo