Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend type checking to all float datatypes #166

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

CeliaBenquet
Copy link
Member

@CeliaBenquet CeliaBenquet commented Aug 23, 2024

This allows for someone to use discrete labels in a continuous way; this might change the solver to behaviors you might not be expecting so please use with caution.

fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/791
fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/790

@cla-bot cla-bot bot added the CLA signed label Aug 23, 2024
@CeliaBenquet CeliaBenquet requested a review from stes August 23, 2024 11:41
@CeliaBenquet CeliaBenquet self-assigned this Aug 23, 2024
@MMathisLab MMathisLab added the enhancement New feature or request label Aug 23, 2024
cebra/data/datasets.py Show resolved Hide resolved
cebra/data/datasets.py Outdated Show resolved Hide resolved
@CeliaBenquet
Copy link
Member Author

CeliaBenquet commented Sep 27, 2024

docs building git action doesn't pass is fixed in #176

@stes
Copy link
Member

stes commented Oct 20, 2024

docs should build again now, main tests not yet. Working on that now.

@stes
Copy link
Member

stes commented Oct 20, 2024

All right, after #184 this should hopefully finally build!

@stes
Copy link
Member

stes commented Oct 20, 2024

Ok, raises an actual error:
image

@CeliaBenquet wanna have a shot at fixing this? otherwise I can have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants