[cuegui] Fix CueGUI version handling and improve error handling #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored version determination logic in Constants.py to avoid repetition and improve readability. - Improved error handling in _get_version_from_cmd function. - Fix errors in Constants_tests.py when cuegui.use.custom.version = True - Centralized default version in a constant. - Updated displayAbout method in MainWindow.py to explicitly check for OPENCUE_BETA environment variable.
ramonfigueiredo
changed the title
ramonfigueiredo
requested review from
bcipriano and
DiegoTavares
as code owners
DiegoTavares
approved these changes
Oct 16, 2024
ramonfigueiredo
merged commit 0f2c98f
into
AcademySoftwareFoundation:master
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuegui/cuegui/Constants.pyto avoid repetition and improve readability.__get_version_from_cmdfunction.cuegui/tests/Constants_tests.pywhencuegui.use.custom.versionis TruedisplayAboutmethod inMainWindow.pyto explicitly check forOPENCUE_BETAenvironment variable.