-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cuegui] feat: Add job node graph plugin v2 #1400
base: master
Are you sure you want to change the base?
Conversation
It's pulling in a specific fork of |
Obviously it fails the python 2 tests, but the PySide6 tests fails because of missing |
After I imported and modified the Have only tested locally with PySide6 and not sure if it will work with PySide2. |
# Conflicts: # cuegui/cuegui/Main.py
I wouldn't worry about python2 now, we're un"officially" not supporting it anymore. |
Commiting the fork as part of this project is not the right approach IMO, as it would prevent us from keeping thing in sync. I see two options to make this dependency maintainable.
Although git submodules are a pain to maintain, I still think 1 is the best option, at least while there's no official release available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bring NodeGraphQt fork as a submodule.
Looks like there has also been some updates to the pyside6 fork, will test with the latest changes to see if it might work |
A did a quick test and atleast with PySide6 it seems to work with just the updated fork. Will need to test it with PySide2 to see if it still requires changes. |
I had to remove the pyside6 test and upgrade python linting to CY2023 (from CY2022) to get all the tests to complete. |
I'm planning to test this feature this week in the SPI environment to confirm we're able to bring the submodule and build it locally. If this works without any issues, I'm okay in merging this in the way it is. If I find it will be a pain to carry this dependency to our environment where downloading things from github is blocked at the network level, we might need to add changes to make this dependency optional. |
Link the Issue(s) this Pull Request is related to.
#888 (original PR)
#1376 (Required)Summarize your change.
This is an adapted PR to support qtpy and PySide6
It requires a fork of NodeGraphQt (https://github.com/jack-mil/NodeGraphQt/tree/pyside6) that has been adapted to use qtpy instead of PySide2/6 directly.