Skip to content

Commit

Permalink
Fix issue on rqd when killing a frame that no longer exists
Browse files Browse the repository at this point in the history
When killing a frame on a rqd node that has restarted and lost track of its running frames, the request should return a status to be handled accordingly and trigger the lostProc logic. The current behaviour leaves the frame stuck at RUNNING until the job itself is killed or eaten.
  • Loading branch information
DiegoTavares committed Oct 8, 2024
1 parent 6e2ed87 commit ac77748
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions rqd/rqd/rqdservicers.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ def KillRunningFrame(self, request, context):
if frame:
frame.kill(message=request.message)
else:
context.set_details(
"The requested frame to kill was not found. frameId: {}".format(
request.frameId))
context.set_code(grpc.StatusCode.NOT_FOUND)
log.warning("Wasn't able to find frame(%s) to kill", request.frame_id)
return rqd.compiled_proto.rqd_pb2.RqdStaticKillRunningFrameResponse()

Expand Down

0 comments on commit ac77748

Please sign in to comment.