Fix call to _mm_cvtps_ph in half.h #448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
_mm_cvtps_ph doesn't support _MM_FROUND_NO_EXC. On Windows, if this is compiled, you will get the following warning: `warning C4556: value of intrinsic immediate argument '8' is out of range '0 - 7'` There is no corresponding instruction, so the flag should be removed. References: https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_cvtps_ph&ig_expand=2244,2221,2220,2221,2252,2220,2221,2220,2221,2221,2107,2252,2107,2107 https://developercommunity.visualstudio.com/t/-mm-cvtps-ph-doesnt-accept-mm-fround-no-exc/1343857 Signed-off-by: John Mather <[email protected]>
|
Thanks for the fix, we're happy to accept it, although our project policy is to require signed CLA forms even for minor contributions. Would you be able to sign the form, following the NOT COVERED link above? If it's too much of a hassle, I can submit a similar fix myself. |
|
Hi Cary, I'm happy to sign the CLA - I'm just in the process of finding out who the manager is on our side so that they can give me the go-ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_mm_cvtps_ph doesn't support _MM_FROUND_NO_EXC. On Windows, if this is compiled, you will get the following warning:
warning C4556: value of intrinsic immediate argument '8' is out of range '0 - 7'There is no corresponding instruction, so the flag should be removed.
References:
https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_cvtps_ph&ig_expand=2244,2221,2220,2221,2252,2220,2221,2220,2221,2221,2107,2252,2107,2107
https://developercommunity.visualstudio.com/t/-mm-cvtps-ph-doesnt-accept-mm-fround-no-exc/1343857