Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyImathEuler.cpp #441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

faizhaque
Copy link

@faizhaque faizhaque commented Oct 3, 2024

For issue #427 Make some changes by converting the Boost.python bindings for the Imath::Euler class to pybind11. Replaced boost.python headers and other changes. Followed the example template so still error testing. Wrappings should be somewhat functional

Make some changes by converting the Boost.python bindings for the Imath::Euler class to pybind11. Replaced boost.python headers and other changes.

Signed-off-by: faizhaque <[email protected]>
Copy link

linux-foundation-easycla bot commented Oct 3, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@faizhaque
Copy link
Author

Also a bit of a disclaimer, this is my first time using pybind11 bindings and my first time experience with this repo. Would appreciate the support!

Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

The code itself looks good, but I'd prefer leave the src/python/PyImath code untouched and put the new pybind11 code in src/pybind11. Can you add a new file src/pybind11/PyBindImath/PyBindImathEuler.cpp with your new code there?

That will place the new code in parallel with the old. Eventually, once all of the classes are covered, we'll remove the old Boost.Python code and replace/rename the new code in its place. But until then, it's helpful to have the two in parallel.

Thanks!

@cary-ilm
Copy link
Member

@faizhaque, we'd like to accept this contribution, but would prefer to see the changes noted above, moving the code into the pybind11 subdirectory. Would you be able to address that soon? If you have any questions, we're happy to help. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants