upgrade GolanCI

AbsaOSS · Dec 20, 2021 · e12929f · e12929f
1 parent ad7d9ae
commit e12929f
Show file tree

Hide file tree

Showing 15 changed files with 43 additions and 4 deletions.
diff --git a/.github/workflows/inspect.yaml b/.github/workflows/inspect.yaml
@@ -25,9 +25,9 @@ jobs:
       - uses: actions/checkout@v2
       # see: https://golangci-lint.run/usage/configuration/#config-file
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2
+        uses: golangci/golangci-lint-action@v2.5.2
         with:
-          version: v1.32
+          version: v1.42.1
       - name: golic
         run: |
           go install github.com/AbsaOSS/[email protected]

diff --git a/.golangci b/.golangci
@@ -7,14 +7,41 @@ linters:
     - gocritic
     - gocyclo
     - goimports
-    - golint
+    - revive
     - gosec
     - gosimple
     - govet
     - ineffassign
     - misspell
     - nakedret
     - lll
+    - noctx
+    - rowserrcheck
+    - staticcheck
+    - structcheck
+    - stylecheck
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    - varcheck
+    - depguard
+    - dogsled
+    - exportloopref
+    - goconst
+    - goprintffuncname
+    - nolintlint
+    - dupl
+    - gochecknoinits
+
+  # don't enable:
+  #  - golint        # deprecated
+  #  - whitespace
+  #  - funlen
+  #  - exhaustive
+  #  - gomnd
+  #  - gofmt
+
 run:
   deadline: 3m
 linters-settings:

diff --git a/.golic.yaml b/.golic.yaml
@@ -39,7 +39,7 @@ golic:
         Generated by GoLic, for more details see: https://github.com/AbsaOSS/golic
   rules:
     .go:
-      prefix: "/*"
+      prefix: "\n/*"
       suffix: "*/"
       under:
         - "package *"

diff --git a/cmd/inject.go b/cmd/inject.go
@@ -1,4 +1,5 @@
 package cmd
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/cmd/remove.go b/cmd/remove.go
@@ -1,4 +1,5 @@
 package cmd
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/cmd/root.go b/cmd/root.go
@@ -1,5 +1,6 @@
 //package provides cobra commands
 package cmd
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/cmd/runner.go b/cmd/runner.go
@@ -1,4 +1,5 @@
 package cmd
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/cmd/version.go b/cmd/version.go
@@ -1,4 +1,5 @@
 package cmd
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/impl/update/config.go b/impl/update/config.go
@@ -1,4 +1,5 @@
 package update
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/impl/update/match.go b/impl/update/match.go
@@ -1,4 +1,5 @@
 package update
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/impl/update/opts.go b/impl/update/opts.go
@@ -1,4 +1,5 @@
 package update
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/impl/update/update.go b/impl/update/update.go
@@ -1,4 +1,5 @@
 package update
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/main.go b/main.go
@@ -1,4 +1,5 @@
 package main
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/utils/guard/guard.go b/utils/guard/guard.go
@@ -1,5 +1,6 @@
 // Package guard throws errors or panics when error occur
 package guard
+
 /*
 Copyright 2022 Absa Group Limited
 

diff --git a/utils/log/log.go b/utils/log/log.go
@@ -1,5 +1,6 @@
 // Package log wraps zerolog logger and provides standard log functionality
 package log
+
 /*
 Copyright 2022 Absa Group Limited