feat: Implement support for PTR records #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fust
requested review from
k0da,
kuritka,
ampie,
januarios,
Buzzglo and
TebogoTS
as code owners
|
Hi @fust , thx a lot for your PR. Excellent! Please, run |
|
@kuritka None of those errors are related to the changes in this MR so I don't really fancy fixing them in this MR. |
|
I corrected the errors |
|
oh I see @fust, makes sense. Will come back to you on the PR. |
|
@furst, please rebase |
fust
force-pushed
the
implement-ptr-records
branch
2 times, most recently
from
7097110
to
cf857d8
Compare
fust
force-pushed
the
implement-ptr-records
branch
from
cf857d8
to
551e59d
Compare
|
Done :) |
kuritka
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PTR records through the
INFOBLOX_CREATE_PTRenvironment variable.