Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Predicate classes into predicates folder #67

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

Dominic-Khoo
Copy link

Refactored NameContainsKeywordsPredicate, TagContainsKeywordsPredicate and NricMatchesPredicate into predicates folder under person package.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...java/seedu/address/logic/commands/ViewCommand.java 84.21% <ø> (ø) 7.00 <0.00> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...rson/predicates/NameContainsKeywordsPredicate.java 100.00% <ø> (ø) 7.00 <0.00> (?)
.../model/person/predicates/NricMatchesPredicate.java 100.00% <ø> (ø) 6.00 <0.00> (?)
...erson/predicates/TagContainsKeywordsPredicate.java 75.00% <ø> (ø) 5.00 <0.00> (?)

Copy link

@reidenong reidenong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dominic-Khoo Dominic-Khoo merged commit 42ca6e8 into AY2425S1-CS2103T-W11-1a:master Oct 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants