Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pop-up window for View command #55

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

itsnotsherm
Copy link

close #52

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 19.04762% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/address/ui/ViewWindow.java 0.00% 22 Missing ⚠️
src/main/java/seedu/address/ui/MainWindow.java 0.00% 10 Missing ⚠️
...java/seedu/address/logic/commands/ViewCommand.java 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 88.88% <ø> (ø) 3.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 100.00% <100.00%> (ø) 15.00 <4.00> (+2.00)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java/seedu/address/logic/commands/ViewCommand.java 84.21% <0.00%> (-15.79%) 7.00 <0.00> (-1.00)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/ViewWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

Copy link

@reidenong reidenong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code looks clean. No issues with checks either.

@reidenong reidenong merged commit e3d7634 into AY2425S1-CS2103T-W11-1a:master Oct 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup for view command
2 participants