Add appointment feature #42
Conversation
There was a problem hiding this comment.
thanks for the detailed comments, code is easily understandable
| /** | ||
| * Returns true if a given string is a valid appointment date. | ||
| */ | ||
| public static boolean isValidAppointment(String test) { |
There was a problem hiding this comment.
maybe this method can be in the appropriate parser instead?
There was a problem hiding this comment.
Agreed, moved to parser. thanks
| @@ -94,13 +104,14 @@ public boolean equals(Object other) { | |||
| && phone.equals(otherPerson.phone) | |||
| && email.equals(otherPerson.email) | |||
| && address.equals(otherPerson.address) | |||
| && tags.equals(otherPerson.tags); | |||
| && tags.equals(otherPerson.tags) | |||
| && Objects.equals(appointment, otherPerson.appointment); // Include appointment in equality check | |||
There was a problem hiding this comment.
could appointment.equals(otherPerson.appointment) work? think narrowing the scope might be safer
There was a problem hiding this comment.
Currently, appointment is deemed as an optional field, as not all patients may have an appointment.
For patients without appointments, their appointment variable holds a null value. With this implementation, appointment.equals(otherPerson.appointment) will trigger a NullPointerException if appointment is null. Using Object.equals() helps to prevent that.
I am also not too sure if this is the best way to go about doing it, can discuss?
Fixes #41