Enable vip status to be initialized as input #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
1st2GetThisName
approved these changes
Nov 7, 2024
| @@ -50,7 +52,9 @@ public AddCommand parse(String args) throws ParseException { | |||
| Comment comment = ParserUtil.parseComment(argMultimap.getValue(PREFIX_COMMENT).orElse(EMPTY_COMMENT)); | |||
| Set<Tag> tagList = ParserUtil.parseTags(argMultimap.getAllValues(PREFIX_TAG)); | |||
|
|
|||
| Person person = new Person(name, phone, email, address, comment, tagList); | |||
| // Parse VIP status; default to false if not provided | |||
| boolean isVip = Boolean.parseBoolean(argMultimap.getValue(PREFIX_VIP).orElse(DEFAULT_VIP)); | |||
There was a problem hiding this comment.
Minor nit: might've made more sense to put this like with the previous paragraph
| @@ -41,7 +42,7 @@ public PersonBuilder() { | |||
| address = new Address(DEFAULT_ADDRESS); | |||
| comment = new Comment(DEFAULT_COMMENT); | |||
| tags = new HashSet<>(); | |||
| isVip = false; | |||
| isVip = DEFAULT_IS_VIP; | |||
1st2GetThisName
merged commit 3213c65
into
AY2425S1-CS2103T-T17-2:master
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.