Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

43 update search command #55

Merged

Conversation

engyuhan
Copy link

fixes #43

@@ -14,7 +14,7 @@
import seedu.address.logic.commands.DeleteCommand;
import seedu.address.logic.commands.EditCommand;
import seedu.address.logic.commands.ExitCommand;
import seedu.address.logic.commands.FindCommand;
import seedu.address.logic.commands.SearchCommand;
import seedu.address.logic.commands.HelpCommand;
import seedu.address.logic.commands.ListCommand;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: eckstyle] [ERROR] /Users/runner/work/tp/tp/src/main/java/seedu/address/logic/parser/AddressBookParser.java:18:1: Wrong lexicographical order for 'seedu.address.logic.commands.HelpCommand' import. Should be before 'seedu.address.logic.commands.SearchCommand'. [CustomImportOrder]

Error: eckstyle] [ERROR] /Users/runner/work/tp/tp/src/main/java/seedu/address/logic/parser/AddressBookParser.java:19:1: Wrong lexicographical order for 'seedu.address.logic.commands.ListCommand' import. Should be before 'seedu.address.logic.commands.SearchCommand'. [CustomImportOrder]

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...va/seedu/address/logic/commands/SearchCommand.java 100.00% <100.00%> (ø) 6.00 <1.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø) 12.00 <0.00> (ø)
...eedu/address/logic/parser/SearchCommandParser.java 100.00% <100.00%> (ø) 3.00 <1.00> (?)

... and 1 file with indirect coverage changes

@RuijianLu RuijianLu merged commit a69b51e into AY2425S1-CS2103T-T17-2:master Oct 10, 2024
4 checks passed
@engyuhan engyuhan deleted the 43-update-search-command branch October 21, 2024 07:09
@engyuhan engyuhan assigned engyuhan and unassigned engyuhan Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Search Command
2 participants