Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deleting customers' contacts based on their names #51

Merged

Conversation

muller317
Copy link

No description provided.

@muller317 muller317 added the type.Enhancement An enhancement to an existing story label Oct 10, 2024
@muller317 muller317 added this to the v1.2 milestone Oct 10, 2024
@muller317 muller317 self-assigned this Oct 10, 2024
@muller317 muller317 linked an issue Oct 10, 2024 that may be closed by this pull request
+ ": Deletes the person identified by the index number used in the displayed person list.\n"
+ "Parameters: INDEX (must be a positive integer)\n"
+ "Example: " + COMMAND_WORD + " 1";
+ ": Deletes the person identified by the index number or the full name used in the displayed person list.\n"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is longer than 120 characterss so it does not pass the java CI.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified, all checks have passed now

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...va/seedu/address/logic/commands/DeleteCommand.java 94.44% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...eedu/address/logic/parser/DeleteCommandParser.java 100.00% <100.00%> (ø) 3.00 <2.00> (+1.00)
...va/seedu/address/logic/commands/DeleteCommand.java 96.96% <94.44%> (-3.04%) 14.00 <2.00> (+7.00) ⬇️

... and 7 files with indirect coverage changes

@engyuhan engyuhan modified the milestones: v1.2, v1.3 Oct 10, 2024
@RuijianLu RuijianLu merged commit 9e9dc42 into AY2425S1-CS2103T-T17-2:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable delete based on customer's name
3 participants