Implement Find command #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find command will not work with the Person class that is modelled after a patient. A find command that is able to search a specific field of a Person will allow the command to be more precise. Let's, * update the Find command to work with the new Person class * include the functionality to search by the id and ward field.
Tests should use FieldContainsKeywordPredicate instead of NameContainsKeywordPredicate. PersonBuilder is lacking the withId and withWard functions. Let's make tests use this FieldContainsKeywordPredicate and implement the withId and withWard functions in PersonBuilder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.