Update Help Window #180
Update Help Window #180
Conversation
FionaQY
requested review from
iamdiluxedbutcooler,
itsme-zeix,
ZShunRen and
colinhia
| @@ -117,23 +88,26 @@ private void initializeCommandTable() { | |||
| "Automatic", | |||
| "No command required"), | |||
There was a problem hiding this comment.
Should we swap the order of commands by its importance, reflecting what we order in the UG
There was a problem hiding this comment.
Here's the most recent version (the status haven't been added to the UG's one yet tho)
There was a problem hiding this comment.
Yup, I think we should follow this (or even consider sorting the commands based on whether they modify data or are purely for viewing).
Saving data should be moved to the bottom as well since users are unlikely to reference it often.
| new CommandSummary("Find a Customer by Details", | ||
| "edit 69 n/ TAN LESHEW p/ 77337733 e/ [email protected] a/ COM3 j/ doctor i/ 1000000000 " | ||
| + "t/ bronze s/ none ra/ Specialist in eye care"), | ||
| new CommandSummary("Find a Client by Details", |
There was a problem hiding this comment.
Further from the UG, it uses "Filter Client List" for action column. Do you think that we should standardize?
There was a problem hiding this comment.
Yeah we should. I'll follow the UG
| + "margin: 0; padding: 0; background-color: #2b2b2b;'>" | ||
| + "<p style='color: #e6e6e6; font-family: \"Segoe UI\", sans-serif; font-size: 14pt; " | ||
| + "text-align: center;'>" | ||
| + "For more information, please refer to the user guide." |
There was a problem hiding this comment.
I think the banner(?) on the UI saying "For more information..." above the button is quite useful and make the help page more user friendly. Can consider bringing it back!
| @@ -61,9 +61,6 @@ dependencies { | |||
| implementation group: 'org.openjfx', name: 'javafx-graphics', version: javaFxVersion, classifier: 'win' | |||
| implementation group: 'org.openjfx', name: 'javafx-graphics', version: javaFxVersion, classifier: 'mac' | |||
| implementation group: 'org.openjfx', name: 'javafx-graphics', version: javaFxVersion, classifier: 'linux' | |||
| implementation group: 'org.openjfx', name: 'javafx-web', version: javaFxVersion, classifier: 'win' | |||
| implementation group: 'org.openjfx', name: 'javafx-web', version: javaFxVersion, classifier: 'mac' | |||
| implementation group: 'org.openjfx', name: 'javafx-web', version: javaFxVersion, classifier: 'linux' | |||
Updates the help window to show the new commands/ changes to old commands and removes JavaFX WebView dependencies.
Closes #174