Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index for help text #153

Merged

Conversation

xGladiate
Copy link

Add index for the invalid indexes or duplicate indexes

Commands with modified changes

  • delete command for both person and delivery when there is duplicate or out-of-bound index
  • archive & unarchive commands for both person and delivery when there is duplicate or out-of-bound index
  • edit command for both person and delivery when the index is out-of-bound
  • inspect command for person when the index is out-of-bound

Example of changes made:

image

@xGladiate xGladiate added this to the v1.5 milestone Nov 1, 2024
@xGladiate xGladiate self-assigned this Nov 1, 2024
@xGladiate xGladiate linked an issue Nov 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...a/seedu/address/logic/commands/ArchiveCommand.java 72.72% 3 Missing ⚠️
...va/seedu/address/logic/commands/DeleteCommand.java 72.72% 3 Missing ⚠️
...seedu/address/logic/commands/UnarchiveCommand.java 72.72% 3 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 94.87% <ø> (ø) 8.00 <0.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 48.67% <100.00%> (+0.27%) 14.00 <0.00> (ø)
...a/seedu/address/logic/commands/InspectCommand.java 59.09% <100.00%> (+11.47%) 5.00 <0.00> (+1.00)
...a/seedu/address/logic/commands/ArchiveCommand.java 57.65% <72.72%> (+5.23%) 21.00 <0.00> (+3.00)
...va/seedu/address/logic/commands/DeleteCommand.java 68.91% <72.72%> (+0.73%) 19.00 <0.00> (ø)
...seedu/address/logic/commands/UnarchiveCommand.java 58.00% <72.72%> (+5.82%) 20.00 <0.00> (+3.00)

@xGladiate xGladiate marked this pull request as ready for review November 1, 2024 07:50
Copy link

@hm-yang1 hm-yang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

}
}

if (duplicate) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Naming of boolean. I had so many warnings from the iP.

@xGladiate xGladiate removed the request for review from kaajinn November 1, 2024 10:25
@xGladiate xGladiate merged commit 5cbce2f into AY2425S1-CS2103T-T12-3:master Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion for multiple delete help text
2 participants