Add Find Address #77
Merged
Add Find Address #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
ahmadsyuaib
approved these changes
Oct 16, 2024
Comment on lines
+103
to
+110
| @Test | ||
| public void parseCommand_findAddress() throws Exception { | ||
| List<String> keywords = Arrays.asList("Tampines", "Street", "1"); | ||
| FindAddressCommand command = (FindAddressCommand) parser.parseCommand( | ||
| FindAddressCommand.COMMAND_WORD + " " + keywords.stream().collect(Collectors.joining(" "))); | ||
| assertEquals(new FindAddressCommand(new AddressContainsKeywordsPredicate(keywords)), command); | ||
| } | ||
|
|
Comment on lines
+19
to
+46
| @Override | ||
| public boolean test(Person person) { | ||
| // Check if any of the keywords match any part of the address | ||
| return keywords.stream() | ||
| .anyMatch(keywords -> person.getAddress().value.toLowerCase().contains(keywords.toLowerCase())); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object other) { | ||
| if (other == this) { | ||
| return true; | ||
| } | ||
|
|
||
| // instanceof handles nulls | ||
| if (!(other instanceof AddressContainsKeywordsPredicate)) { | ||
| return false; | ||
| } | ||
|
|
||
| AddressContainsKeywordsPredicate otherAddressContainsKeywordsPredicate = | ||
| (AddressContainsKeywordsPredicate) other; | ||
| return keywords.equals(otherAddressContainsKeywordsPredicate.keywords); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return new ToStringBuilder(this).add("keywords", keywords).toString(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Nicely formatted and arranged code!
| @@ -8,7 +8,7 @@ | |||
| import seedu.address.model.person.NameContainsKeywordsPredicate; | |||
|
|
|||
| /** | |||
| * Finds and lists all persons in address book whose name contains any of the argument keywords. | |||
| * Finds and lists all persons in ClientHub whose name contains any of the argument keywords. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things Done
close #65