Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FindClientType Command #64

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

jereeemyyyy
Copy link

@jereeemyyyy jereeemyyyy commented Oct 15, 2024

close #59

Add FindClientTypeCommand, FindClientTypeCommandParser,
ClientTypeContainsKeyword for the new short cut find client type
command.
Update ClientHubParser to account for the case when the command is
"fc" which is the short cut command for find ClientType.
Fix the checkstyle according to CS2103T coding standards for the new
classes created
Resolved merge conflict.
Add FindClientTypeCommand and the relevant classes
@jereeemyyyy jereeemyyyy added this to the v1.3 milestone Oct 15, 2024
Copy link

@rubinnn rubinnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation of the FiendClientType Command. Good OOP and abstraction of the method.

@rubinnn rubinnn merged commit 3183641 into AY2425S1-CS2103T-F10-1:master Oct 16, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FindClientType Command
2 participants