Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch reminder edit #246

Merged

Conversation

Harithhh06
Copy link

Things done

  • Implement edit feature for reminder
  • Updated error message for add reminder

close #190

@Harithhh06 Harithhh06 added this to the v1.5 milestone Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 70 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/logic/commands/reminder/EditReminderCommand.java 0.00% 53 Missing ⚠️
...gic/parser/reminder/EditReminderCommandParser.java 0.00% 17 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...ss/logic/commands/reminder/AddReminderCommand.java 91.66% <ø> (+91.66%) 8.00 <0.00> (+8.00)
...gic/parser/reminder/EditReminderCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...s/logic/commands/reminder/EditReminderCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 11 files with indirect coverage changes

public static final String COMMAND_WORD = "re"; // reminder edit

public static final String MESSAGE_USAGE = COMMAND_WORD + ": Edits a reminder in the address book identified "
+ "by the index number displayed in the reminder list. "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear structure of edit reminder command!

@L-rrrr
Copy link

L-rrrr commented Nov 5, 2024

Good!

@L-rrrr L-rrrr merged commit e113363 into AY2425S1-CS2103T-F10-1:master Nov 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Edit feature for Reminder
2 participants