Fix bug when max scores were negative, and feedback given #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative max scores caused a bug As a side-effect of the fix, error messages may not be as specific, specifically, entering a negative score for the grade command
lm-44
added
type.Bug
avrilmohh
reviewed
Oct 22, 2024
Comment on lines
+79
to
+85
| try { | ||
| int value = Integer.parseInt(s); | ||
| // "-0" and "+0" is successfully parsed by Integer#parseInt(String) | ||
| return value >= 0 && !s.startsWith("+") && !s.startsWith("-"); | ||
| } catch (NumberFormatException nfe) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Good job on ensuring the input is a valid unsigned integer and not a signed one.
jian7490
reviewed
Oct 23, 2024
| throw new ParseException(String.format(MESSAGE_INVALID_COMMAND_FORMAT, | ||
| AddAssignmentCommand.MESSAGE_USAGE), pe); | ||
| throw new ParseException( | ||
| String.format(MESSAGE_INVALID_COMMAND_FORMAT, AddAssignmentCommand.MESSAGE_USAGE), pe); |
There was a problem hiding this comment.
Good formatting to follow coding standard
Comment on lines
-121
to
+125
| int parsedScore; | ||
| try { | ||
| parsedScore = Integer.parseInt(trimmedMaxScore); | ||
| } catch (NumberFormatException e) { | ||
| throw new ParseException("The score must be an integer!"); | ||
| if (!StringUtil.isUnsignedInteger(trimmedMaxScore)) { | ||
| throw new ParseException(Assignment.MAX_SCORE_MESSAGE_CONSTRAINTS); | ||
| } | ||
| return parsedScore; | ||
| return Integer.parseInt(trimmedMaxScore); |
There was a problem hiding this comment.
This is a similar issue happening in gradeAssignmentCommand. Great attempt to simplify the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative max scores caused a bug
As a side-effect of the fix, error messages may not be as specific, specifically, entering a negative score for the grade command