workloads/speedometer: Dismiss notification pop-up #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcbonnici
approved these changes
May 28, 2024
| @@ -204,6 +204,7 @@ def setup(self, context): | |||
| '<boolean name="first_run_tos_accepted" value="true" />\n', | |||
| '<boolean name="first_run_signin_complete" value="true" />\n', | |||
| '<boolean name="displayed_data_reduction_promo" value="true" />\n', | |||
| '<int name="Chrome.NotificationPermission.RequestCount" value="2" />\n', | |||
There was a problem hiding this comment.
nit: Would it be worth adding a comment to the code so we know what this line had been added to achieve going forward?
When speedometer is running on a Chrome package on Android 14, a pop-up window was showing on the screen. Chrome preferences file is modified to dismiss the window.
marcbonnici
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When speedometer is running on a Chrome package on Android 14, a pop-up window was showing on the screen. Chrome preferences file is modified to dismiss the window.