WIP Location json #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@faace can I get an help on this? |
mingiryu
reviewed
Jun 24, 2020
mingiryu
reviewed
Jun 24, 2020
| @@ -0,0 +1,26 @@ | |||
| window.multiLocationsTemplate = `{ | |||
There was a problem hiding this comment.
This might be the one I was looking for. I'm wondering why we are using stringified JSON as a template, wouldn't it be better to have a JSON object instead?
There was a problem hiding this comment.
It's temporary. you can changed it in object.
|
@faace I have aligned with master branch. Are you able to work on this? Ask me for help if needed. |
|
@nicolocarpignoli still actual? |
|
@nicolocarpignoli yes, it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #49