Update processor_alpaca.py #1185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update processor_alpaca to use the new Alpaca-Py instead of the deprecated alpaca-trade-api
for more information, see https://pre-commit.ci
|
thanks for your work. |
|
Yes, Alpaca-trade-api is now deprecated (see deprecation notice here: https://github.com/alpacahq/alpaca-trade-api-python ), and is replaced by Alpaca-py ( https://github.com/alpacahq/alpaca-py ). I have tested this file and it works. There is an issue, however, as I was unable to completely change alpaca.py (found at https://github.com/AI4Finance-Foundation/FinRL/blob/master/finrl/meta/paper_trading/alpaca.py ) because there are some functions that Alpaca-trade-api has that Alpaca-py does not. Apologies for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update processor_alpaca to use the new Alpaca-Py instead of the deprecated alpaca-trade-api.
Might be a bit inefficient due to changing the dataframe structure output by Alpaca-Py to match alpaca-trade-api's outputted dataframe structure, in an effort to minimize errors that this might cause in other files.