Fix: Unicorn build paths in top-level Makefile and Rust bindings' build.rs #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues while trying to use the Rust bindings and eventually realized that the Unicorn build directory used in the top-level Makefile didn't match the paths used in
bindings/rust/build.rs.This PR updates the Unicorn build path in
Makefileto usebuild/unicornso that it's created in the location wherebuild.rsexpects it to be. Another minor change was also made tobindings/rust/src/lib.rsto remove warnings about globbed re-exported symbols.