Skip to content

Commit

Permalink
chore: update to node 18
Browse files Browse the repository at this point in the history
Local development now uses node 18, and we test 14 through 18 in CI
  • Loading branch information
Yogu committed Jan 16, 2023
1 parent 798827f commit 2131ddb
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
strategy:
matrix:
arango-image: ['arangodb:3.6', 'arangodb:3.7', 'arangodb:3.8', 'arangodb:3.9']
node-version: [14.x, 16.x]
node-version: [14.x, 16.x, 18.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -38,7 +38,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm publish --tag next
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@types/deep-equal-in-any-order": "^1.0.1",
"@types/lodash": "^4.14.184",
"@types/mocha": "^9.1.1",
"@types/node": "^16.11.43",
"@types/node": "^18.11.18",
"@types/pluralize": "0.0.29",
"@types/uuid": "^8.3.4",
"ajv-cli": "^5.0.0",
Expand Down
3 changes: 2 additions & 1 deletion spec/regression/initialization.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import stripJsonComments from 'strip-json-comments';
import { ArangoDBConfig } from '../../src/database/arangodb';

const DATABASE_NAME = 'cruddl-test-temp';
const DATABASE_URL = 'http://root:@localhost:8529';
// arangodb only listens on ipv4, but localhost may resolve to ::1, so explicitly state 127.0.0.1
const DATABASE_URL = 'http://root:@127.0.0.1:8529';

export async function createTempDatabase(): Promise<ArangoDBConfig> {
const systemDatabase = new Database({
Expand Down

0 comments on commit 2131ddb

Please sign in to comment.