Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote ui READMEs to reflect current layout #106

Merged
merged 8 commits into from
Jul 21, 2020
Merged

Rewrote ui READMEs to reflect current layout #106

merged 8 commits into from
Jul 21, 2020

Conversation

sverhoeven
Copy link
Member

Refs #101

jspaaks
jspaaks reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think we should hoist the text about example searches to the top level as well? We should probably also include the test queries in the CI.

fdiblen
fdiblen approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guided my life.
📚

@sverhoeven
Copy link
Member Author

sverhoeven commented Jul 20, 2020 •
edited
Loading

I don't want to pollute the main readme with curl statements, I can mention the web service in the main rreadme and point to the curls in ui/README. Is that OK?

CI addition will be done in #108

@fdiblen fdiblen mentioned this pull request Jul 20, 2020
Open
@sverhoeven sverhoeven requested a review from jspaaks July 20, 2020 16:00
@fdiblen
Copy link
Contributor

fdiblen commented Jul 21, 2020

I don't want to pollute the main readme with curl statements, I can mention the web service in the main rreadme and point to the curls in ui/README. Is that OK?

CI addition will be done in #108

Sounds OK to me.

@jspaaks jspaaks self-assigned this Jul 21, 2020
jspaaks
jspaaks suggested changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@jspaaks jspaaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes.
🐨

ui/README.md Outdated Show resolved Hide resolved
ui/ui/README.md Outdated Show resolved Hide resolved
ui/README.md Outdated Show resolved Hide resolved
ui/ui/README.md Show resolved Hide resolved
ui/ui/README.md Outdated Show resolved Hide resolved
@sverhoeven sverhoeven merged commit 7c271ca into master Jul 21, 2020
@sverhoeven sverhoeven deleted the 101-ui-docs branch July 21, 2020 13:50
@jspaaks jspaaks mentioned this pull request Aug 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspaaks jspaaks jspaaks requested changes

@fdiblen fdiblen fdiblen approved these changes

Assignees

@jspaaks jspaaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sverhoeven @fdiblen @jspaaks