base weapon recoil generation change+ small bugfix + hybrid trace changes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Removed intense screenshake from aimpunch produced by high latency -Added client initiated muzzle climb recoil -Fixed recoil and aimpunch being applied while sprinting
LiddulBOFH
requested changes
Sep 30, 2024
There was a problem hiding this comment.
May want to still keep Ply as a localized version of the player, calling self.Owner repeatedly is not good for performance due to the extremely inefficient metatable index entities have, and self:GetOwner() is preferred over self.Owner
"IFTP" is also not needed as it is only being used once, not to mention its being defined in the global space when it should be localized
"ang" should also be localized
requested changes to base weapon code from pr requested has been applied
|
changes have been applied |
missed a line
-Hybrid trace now only initiates when hitting Player or NPC -Added selectable effect to hybrid trace. BloodImpact and ACF_Penetration. -linterhell (a.)
LeninCat
changed the title
|
-hybrid trace changes added (effects added) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Removed intense screenshake from aimpunch produced by high latency
-Added client initiated muzzle climb recoil
-Fixed recoil and aimpunch being applied while sprinting