Update docker-testkit-core, ... to 0.11.0 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unclear to me how we got a scala-steward PR for a library version that doesn't seem ever to have existed (https://search.maven.org/artifact/com.whisk/docker-testkit-impl-spotify_2.13/0.11.0-beta1/jar, though maybe there was a bad publication adventure 🤔) BUT changes based on the actually published 0.11.x version (-beta1) were pretty small and tests passed locally for me |
there's a symbol missing from the classpath which always points to bin compat SO I ran unused/undeclared compile deps from sbt-explicit-dependencies and found this had been upgraded by the other dep upgrade
|
I've fired up nix shells locally with super recent java (17), 11, and 8, and can't replicate the build failures here. Pausing on this adventure until I can confirm that this library is in use / time spent defeating the CI-only build failure is more valuable than migration to testcontainers for anything that depends on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
from 0.9.9 to 0.11.0.
GitHub Release Notes
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Files still referring to the old version number
The following files still refer to the old version number (0.9.9).
You might want to review and update them manually.
Ignore future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:labels: library-update, early-semver-major, semver-spec-minor, old-version-remains