pikvm_comm.py: add local image upload kwd #16
Conversation
|
|
||
|
|
||
| @keyword("Copy Image PIKVM") | ||
| def CopyImagePiKVM( |
There was a problem hiding this comment.
@wiktormowinski It seems like this is almost identical to UploadImagePiKVM with a single change of removing ?url= from the request.
Why not use another function to share the common code between these two?
Also, I would suggest to use better naming, so it's obvious that one kwd works on file, while the second one works on URL. Now you simply changed Upload to Copy. We still perform the upload, but simply from local path, not from the remote URL. It's been changed for the sake of being different, but it's name does not really tell much.
Better names could be something like: Upload From File / Upload From URL. Or even further, if these keywords are so similar, you can make it accept both URL and local path, and then adjust request accordingly. Either automatically based on the argument, or manually, by introducing second argument which switches between file and URL.
No description provided.