Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeaturesTable improvements #4922

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

FeaturesTable improvements #4922

wants to merge 8 commits into from
+261 −67

Conversation

neo-garaix
Copy link
Contributor

@neo-garaix neo-garaix commented Oct 29, 2024 •
edited
Loading

Add

  • Replaced some "div" by "table" tags such as "tr", "th" ...
  • Added columns compatibility : now we can add several columns through some <lizmap-field ... > ... </lizmap-field>
  • Added header labels of columns
  • Added regex verification for expressions in fields

Fix

  • Fixed the end2end playwright test about FeaturesTable

Funded by 3liz

@github-actions github-actions bot added this to the 3.10.0 milestone Oct 29, 2024
@Gustry Gustry added run end2end If the PR must run end2end tests or not backport release_3_8 backport release_3_9 labels Oct 29, 2024
mdouchin
mdouchin requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a <td> inside the <tr> to anticipated further column usage. Hopefully this will not break the current features

mdouchin
mdouchin approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mdouchin
Copy link
Collaborator

Please rebase your commits into one single commit (with a new commit message and description) and it will be mergeable
Thanks

mdouchin
mdouchin requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕

assets/src/components/FeaturesTable.js Outdated Show resolved Hide resolved
assets/src/components/FeaturesTable.js Outdated Show resolved Hide resolved
assets/src/components/FeaturesTable.js Outdated Show resolved Hide resolved
assets/src/components/FeaturesTable.js Outdated Show resolved Hide resolved
assets/src/modules/FeaturesTable.js Outdated Show resolved Hide resolved
assets/src/modules/FeaturesTable.js Outdated Show resolved Hide resolved
lizmap/modules/lizmap/controllers/features.classic.php Outdated Show resolved Hide resolved
@Gustry Gustry mentioned this pull request Nov 6, 2024
Draft
@neo-garaix neo-garaix changed the title Update of FeaturesTable to use "table" HTML tags FeaturesTable improvements Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustry Gustry Gustry left review comments

@mdouchin mdouchin mdouchin requested changes

@rldhont rldhont Awaiting requested review from rldhont

Assignees

@mdouchin mdouchin

Labels
backport release_3_8 backport release_3_9 run end2end If the PR must run end2end tests or not
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@neo-garaix @mdouchin @rldhont @Gustry