[Bugfix] Too many embedded layers cause php to hit max_execution_time

[mind84]

There are cases where a project might embed several layers from another project.

In this scenario Lizmap loads the same project (embedded project) multiple times for each of these layers and this behavior could cause php to hit max_execution_time if there are many embedded layers.

To fix that I've grouped the embedded layers and load the related QGIS embedded project once.

Test note
I haven't add php unit tests since seems to me that the current tests already covers this changes. Of course, if you think that more tests are needed, I'll add them.

Funded by Faunalia

[Gustry]

I guess it should be backported to 3.7 right ? 3.6 as well ?

[mind84]

I guess it should be backported to 3.7 right ? 3.6 as well ?

I think 3.7. Don't know for 3.6

Thanks a lot

[mind84]

I ran project_homepage e2e cypress test on a clean master branch and it fails at the same point.

        cy.get('.liz-project-title:contains("Test tags: nature, flower")')
            .prev('.liz-project')
            .children('.liz-project-desc').as('all-metadata') //<------- fails to get children('.liz-project-desc')

Should I update the test file too?

Seems not related to this pr.

[mind84]

I ran project_homepage e2e cypress test on a clean master branch and it fails at the same point.

        cy.get('.liz-project-title:contains("Test tags: nature, flower")')
            .prev('.liz-project')
            .children('.liz-project-desc').as('all-metadata') //<------- fails to get children('.liz-project-desc')

Should I update the test file too?

Seems not related to this pr.

the same on this pr #4024

[Gustry]

Should I update the test file too?

It's a work in progress already, you can skip this failing test.

[mind84]

@Gustry,

can you please wait to merge this one? I've found another part that cause the same issue, pretty much the same behavior, and I would try to fix that part too.

[rldhont]

@mind84 you have requested to do not merged. You have marked the PR as Ready to review, yesterday. It is really ready to review and merged ?

[mind84]

@mind84 you have requested to do not merged. You have marked the PR as Ready to review, yesterday. It is really ready to review and merged ?

Yes, I've done all changes, thanks

[nworr]

i remove my approval, need to review the changes

[Gustry]

Let us know when this PR is finished, so the review can be done, we see you are still pushing on the branch

[mind84]

Yes, I've done all changes, thanks

Hi @Gustry,

I've completed my changes yesterday, I'm just continue rebasing to let you merge the pr.
I think @nworr wants to review the code.

Thanks you

[mind84]

The code is not changed since @rldhont approval

[Gustry]

There a lot of merged PR today, do not worry for now about all these latest commits.
I though you were working on your PR and updating the code. We just have a notification saying your pull request has been updated, so not making the review easy.

[mdouchin]

Thanks a lot