[CI] Fix phpstan errors and freeze version

3liz · Aug 27, 2024 · dbbe820 · dbbe820
1 parent b9429b9
commit dbbe820
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/.github/workflows/php-stan.yml b/.github/workflows/php-stan.yml
@@ -31,7 +31,7 @@ jobs:
         # About the PHP version, do not forget to change in PHP Unit as well
         with:
           php-version: '8.0'
-          tools: phpstan
+          tools: phpstan:1.11.11
 
       - name: Cache dependencies
         uses: actions/cache@v4

diff --git a/lizmap/modules/lizmap/classes/lizmap.class.php b/lizmap/modules/lizmap/classes/lizmap.class.php
@@ -138,7 +138,6 @@ public static function getRepositoryProperties()
     {
         trigger_error('This method is deprecated. Please use the lizmapRepository::getProperties() method.', E_DEPRECATED);
 
-        // @phpstan-ignore deadCode.unreachable
         return lizmapRepository::$properties;
     }
 
@@ -152,7 +151,6 @@ public static function getRepositoryPropertiesOptions()
     {
         trigger_error('This method is deprecated. Please use the lizmapRepository::getPropertiesOptions() method.', E_DEPRECATED);
 
-        // @phpstan-ignore deadCode.unreachable
         return lizmapRepository::$propertiesOptions;
     }