Support latest 8.x release #330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulldecent
commented
May 14, 2024
fulldecent
commented
| Questions | Answers |
|---|---|
| Description? | Add testing support for latest PS versions |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| How to test? | Automated tests run |
clotairer
requested changes
May 14, 2024
| @@ -70,7 +70,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| presta-versions: ['1.7.4.0', '8.0.4'] | |||
| presta-versions: ['1.7.4.0', '8.0.4', '8'] # These are prestashop/prestashop Docker tag versions | |||
There was a problem hiding this comment.
Interesting suggestion.
At this step we prefer launch phpstan for only two defined PrestaShop release.
There was a problem hiding this comment.
Right now only the 8 version is officially supported. Source: https://github.com/PrestaShop/PrestaShop/security#supported-versions
Should I update it to just that instead?
There was a problem hiding this comment.
If we add « 8 », « 8.0.4 » is probably not pertinent if PHP version of the docker images are the same.
Why do you choose 8 and not latest ?
There was a problem hiding this comment.
I was afraid that latest might be the 9 development. If there is a convention (undocumented) that latest means the latest release version then I agree that is best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.