Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare sendIdentifiedPRotocol so MQTTtoIR finds it #840

Merged
merged 2 commits into from
Dec 31, 2020

Conversation

chesterbr
Copy link
Contributor

When building v0.9.5 on Arduino IDE 1.8.13, in either macOS 10.15.17 (Catalina) or 11.1 (Big Sur), I got this error:

ZgatewayIR:258:90: error: 'sendIdentifiedProtocol' was not declared in this scope
         signalSent = sendIdentifiedProtocol(protocol_name, data, hex, valueBITS, valueRPT);
                                                                                          ^

This fix declares the sendIdentifiedPRotocol function, so the MQTTtoIR one compiles it.

I could also just swap the order, or try to simplify the declaration (if possible; wasn't sure about style/side effects), just let me know!

Thanks again for maintaining this amazing application.

Full error log
Arduino: 1.8.13 (Mac OS X), Board: "NodeMCU 1.0 (ESP-12E Module), 80 MHz, Flash, Legacy (new can return nullptr), All SSL ciphers (most compatible), 4MB (FS:2MB OTA:~1019KB), 2, v2 Lower Memory, Disabled, None, Only Sketch, 115200"











/Users/chesterbr/chesterbr/private-OpenMQTTGateway/main/ZgatewayIR.ino: In function 'void MQTTtoIR(char*, ArduinoJson::JsonObject&)':
ZgatewayIR:258:90: error: 'sendIdentifiedProtocol' was not declared in this scope
         signalSent = sendIdentifiedProtocol(protocol_name, data, hex, valueBITS, valueRPT);
                                                                                          ^
exit status 1
'sendIdentifiedProtocol' was not declared in this scope


This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

Avoids this compilation error on Arduino IDE 1.8.13:

```c
ZgatewayIR:258:90: error: 'sendIdentifiedProtocol' was not declared in this scope
         signalSent = sendIdentifiedProtocol(protocol_name, data, hex, valueBITS, valueRPT);
```                                                                                          ^
I *think* that was the linter complaint (given it shows no message, and before/after parts in diff are visually identical
@1technophile
Copy link
Owner

Perfect, thanks for the PR

@1technophile 1technophile added this to the v0.9.6 milestone Dec 31, 2020
@1technophile 1technophile merged commit e486574 into 1technophile:development Dec 31, 2020
@chesterbr chesterbr deleted the patch-1 branch January 1, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants