sonoff rfbridge direct hack - first commit #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, could you isolate the change to the added environment, please. |
|
Moved new environment to end of file to prevent other changes. Removed "uncomment" listing for this environment from top section. Sorry, I'm not very good with git. |
|
No problem, you need also to add |
|
Perfect, thanks |
platformio.ini
Outdated
| lib_deps = | ||
| ${com-esp.lib_deps} | ||
| ${libraries.esp8266_mdns} | ||
| puuu/ESPiLight@^0.17.0 |
There was a problem hiding this comment.
Could you call
${libraries.esppilight}
instead please
|
Just one comment :-) |
platformio.ini
Outdated
| lib_deps = | ||
| ${com-esp.lib_deps} | ||
| ${libraries.esppilight} | ||
| puuu/ESPiLight@^0.17.0 |
There was a problem hiding this comment.
You are right mdns is not necessary here.
You should also remove :
puuu/ESPiLight@^0.17.0
Since it is called by
${libraries.esppilight}
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds environment directive to platform.io for Sonoff RF Bridge modified with "direct hack" allowing bypass of efm8bb1 microcontroller. ( https://github.com/xoseperez/espurna/wiki/Hardware-Itead-Sonoff-RF-Bridge---Direct-Hack ).