HASS Discovery - Create BLE devices automatically to gather entities

[titilambert]

As discuted here: #821

Note that I'm not so good with C++, so I guess the code it's no so clean ...

[titilambert]

Is there any way to fmt the code with a command line ? (like go fmt )

[Legion2]

clang-Format is used for code formatting

[titilambert]

Ready for review
Again, I guess my code is not so clean, I'm not familiar with C++

[1technophile]

Here is a first list of comments

[aswarcewicz]

Is it possible to include change in 0.9.6 milestone?

[titilambert]

@1technophile thanks again for reviewing the PR !
Hopefully, I'm close to get it done !

[titilambert]

@1technophile the following line

(char*)String(p->sensorModel).c_str()

return a number (in my case 7). I guess it's the index in ble_sensor_model.
How can I get the good string instead ?

[Legion2]

The number is the pointer to the string in the memory, C and C++ do not have string as a native type.

[1technophile]

How can I get the good string instead ?

Well, indeed this return an int ...

I think we may store the sensor characteristics (model, manufacturer,code) in a dedicated list.
I can do it in a separate PR, for the moment you can put the sensor model hardcoded.

[1technophile]

Once your changes are done we will need to rebase this PR = merge the changes from the development branch to this PR ( I can do it if needed).

[1technophile]

Hi @titilambert , would you have time to finish the PR?

[titilambert]

@1technophile sorry ! It's done and rebased

[1technophile]

No problem ! Thanks

[titilambert]

@1technophile any idea why the build crashes ?

[1technophile]

@titilambert You can take a look below (search for FAILED):
https://github.com/1technophile/OpenMQTTGateway/runs/1574425197?check_suite_focus=true

Some createDiscovery functions are missing the 4 new parameters:
"", "", "", "" // device name, device manufacturer, device model, device mac

This is related to the rebasing/merge and seems isolated to M5 boards.

[titilambert]

@titilambert You can take a look below (search for FAILED):
https://github.com/1technophile/OpenMQTTGateway/runs/1574425197?check_suite_focus=true

Some createDiscovery functions are missing the 4 new parameters:
"", "", "", "" // device name, device manufacturer, device model, device mac

This is related to the rebasing/merge and seems isolated to M5 boards.

Sorry I don't see where it is in the code.
Can you help ?

[1technophile]

Can you help ?

@titilambert of course, here is how to find it:

[1technophile]

Test ok with HASS 2020.12.7

Note that I had to restart HASS

[1technophile]

Thanks!