Add a macro to use the MAC address as the gateway name. #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the macro USE_MAC_AS_GATEWAY_NAME, when defined the gateway name will default to OMG_XXXXXXXXXXXX, where the X's are the mac address characters. This can still be changed in WiFiManager.
|
@h2zero Tks very much for this, I had been doing it manually for a while now. |
|
@h2zero I just updated my devices with the latest beta, and the OTA device name is not the expected Mac address but 'OpenMQTTGateway', shouldn't this use the Mac address as the OTA Device name as well ? |
|
@NorthernMan54 Thanks for pointing this out, it had not occurred to me to change this as well. I will submit a PR to rectify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the macro USE_MAC_AS_GATEWAY_NAME, when defined the gateway name will default to:
OMG_XXXXXXXXXXXX, where the X's are the mac address characters.
This can be changed in WiFiManager.
Checklist: