Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for dataconv: fix StarString, add GoToStarlarkViaJSON #119

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Conversation

hyorigo
Copy link
Collaborator

@hyorigo hyorigo commented Aug 12, 2024

  • draft for fix
  • renaming

Copy link

codacy-production bot commented Aug 12, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (97c1c1f) 5443 5106 93.81%
Head commit (f209197) 5442 (-1) 5105 (-1) 93.81% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#119) 17 17 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (97c1c1f) to head (f209197).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   91.68%   91.68%   -0.01%     
==========================================
  Files          44       44              
  Lines        5292     5291       -1     
==========================================
- Hits         4852     4851       -1     
  Misses        331      331              
  Partials      109      109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyorigo hyorigo changed the title for dataconv: fix StarString, add StarString for dataconv: fix StarString, add GoToStarlarkViaJSON Aug 12, 2024
@hyorigo hyorigo merged commit 6f89608 into master Aug 12, 2024
24 of 25 checks passed
@hyorigo hyorigo deleted the fixhelp branch August 12, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant