who encodes

dataconv/interface.go

@@ -2,14 +2,14 @@ package dataconv
 
 import "go.starlark.net/starlark"
 
-// Unmarshaler is the interface use to unmarshal Starlark custom types.
+// Unmarshaler is the interface use to unmarshal Starlark values to custom types.
 type Unmarshaler interface {
-	// UnmarshalStarlark unmarshal a starlark object to custom type.
+	// UnmarshalStarlark unmarshal a Starlark object to custom type.
 	UnmarshalStarlark(starlark.Value) error
 }
 
-// Marshaler is the interface use to marshal Starlark custom types.
+// Marshaler is the interface use to marshal Starlark from custom types.
 type Marshaler interface {
-	// MarshalStarlark marshal a custom type to starlark object.
+	// MarshalStarlark marshal a custom type to Starlark object.
 	MarshalStarlark() (starlark.Value, error)
 }

dataconv/marshal.go

@@ -12,7 +12,7 @@ import (
 	"go.starlark.net/starlarkstruct"
 )
 
-// Unmarshal decodes a starlark.Value into it's Golang counterpart.
+// Unmarshal converts a starlark.Value into it's Golang counterpart.
 func Unmarshal(x starlark.Value) (val interface{}, err error) {
 	switch v := x.(type) {
 	case starlark.NoneType:
@@ -40,7 +40,7 @@ func Unmarshal(x starlark.Value) (val interface{}, err error) {
 			kval    interface{}
 			keys    []interface{}
 			vals    []interface{}
-			// key as interface if found one key is not a string
+			// use interface{} as key type if found one key is not a string
 			ki bool
 		)
 		for _, k := range v.Keys() {
@@ -159,7 +159,7 @@ func Unmarshal(x starlark.Value) (val interface{}, err error) {
 				}
 			}
 			val = jo
-			//err = fmt.Errorf("constructor object from *starlarkstruct.Struct not supported Marshaler to starlark object: %T", v.Constructor())
+			//err = fmt.Errorf("constructor object from *starlarkstruct.Struct not supported Marshaler to Starlark object: %T", v.Constructor())
 		}
 	case *convert.GoSlice:
 		if IsInterfaceNil(v) {
@@ -193,7 +193,7 @@ func Unmarshal(x starlark.Value) (val interface{}, err error) {
 	return
 }
 
-// Marshal turns Go values into Starlark types. It only supports common Go types, won't wrap any custom types like Starlight does.
+// Marshal converts Go values into Starlark types. It only supports common Go types, won't wrap any custom types like Starlight does.
 func Marshal(data interface{}) (v starlark.Value, err error) {
 	switch x := data.(type) {
 	case nil:

dataconv/marshal_test.go

@@ -267,7 +267,6 @@ func (c *customType) UnmarshalStarlark(v starlark.Value) error {
 	}
 
 	// TODO: refactoring transform data
-
 	mustInt64 := func(sv starlark.Value) int64 {
 		i, _ := sv.(starlark.Int).Int64()
 		return i