Three-page "who" form section #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial construction of our three page "who" section of the special uses form. It implements some of the conditional logic from our content design, but we only have the page 2 content for a corporation, not for a partnership or agency. It also doesn't currently have the code to replace the word "entity" on page 2 with the particular entity type that people responded with on page 1, but the occurrences that need to be subbed out are marked with
<span class="entity-type">so it should be straightforward to code up a handler to replace those at page load time.The conditional logic also got complicated enough that it is worth including a testing library for the behavior of the page. We use Cypress for end-to-end testing and define our desired behaviors in
cypress/e2e/*.cy.js. We also run those tests now in our CI/CD job.